unpin pyarrow for windows #42097
Merged
unpin pyarrow for windows #42097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
step 1: release the pin. Let's see what tests fail? |
|
I also ran the test added in #29993 locally and it passed. |
|
cc @anyscalesam |
|
I think releasing the pin is enough to solve the issue. |
Signed-off-by: mattip <[email protected]>
|
I don't think the CI failure is related. It would be nice to get some eyes on this. |
|
CI failure is likely unrelated. Updating branch to re-run |
|
Contents of PR LGTM - I triggered a postmerge test to see how things look on windows tests. |
edoakes
approved these changes
Jan 25, 2024
khluu
pushed a commit
that referenced
this pull request
Jan 27, 2024
Toward fixing #38300 PR #29993 added a local ray fix for issue apache/arrow#26685, but at the time windows failed the tests with pyarrow7. In issue #38300 the suggested fix was to release the pin. Signed-off-by: mattip <[email protected]> Co-authored-by: Edward Oakes <[email protected]> Signed-off-by: khluu <[email protected]>
|
Could we pick that for 2.9.2? |
|
When will this fix be released. It introduced installation issue for AutoGluon on Windows platform with Python 3.11 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Toward fixing #38300
PR #29993 added a local ray fix for issue apache/arrow#26685, but at the time windows failed the tests with pyarrow7. In issue #38300 the suggested fix was
_register_arrow_data_serializer(), and include an environment variable to override the Pyarrow version checkChecks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.