[ci][mac/1] move macos small test to civ2 #42023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can-anyscale
force-pushed
the
can-mac01
branch
4 times, most recently
from
e9b6bb2
to
d2361ce
Compare
can-anyscale
force-pushed
the
can-mac01
branch
9 times, most recently
from
47038ee
to
c511807
Compare
can-anyscale
force-pushed
the
can-mac01
branch
4 times, most recently
from
50994b1
to
0f27162
Compare
can-anyscale
changed the title
aslonnie
reviewed
Jan 3, 2024
ci/ray_ci/macos/macos_ci.sh
Outdated
|
|
||
| set -ex | ||
|
|
||
| export BUILDKITE="true" |
There was a problem hiding this comment.
this BUILDKITE=true is not required? shouldn't this be populated already?
ci/ray_ci/macos/macos_ci.sh
Outdated
| mkdir -p /tmp/artifacts/.ray/ | ||
| tar -czf /tmp/artifacts/.ray/logs.tgz /tmp/ray | ||
| # Cleanup runtime environment to save storage | ||
| rm -rf /tmp/ray || true |
There was a problem hiding this comment.
remove || true? -rf never fails.
ci/ray_ci/macos/macos_ci.sh
Outdated
| ./ci/ci.sh build | ||
| ./ci/env/env_info.sh | ||
|
|
||
| $1 |
There was a problem hiding this comment.
add a "$@" to send in the args maybe?
ci/ray_ci/macos/macos_ci.sh
Outdated
Comment on lines
25
to
31
| rm -rf /tmp/bazel_event_logs | ||
| cleanup() { if [ "${BUILDKITE_PULL_REQUEST}" = "false" ]; then ./ci/build/upload_build_info.sh; fi }; trap cleanup EXIT | ||
| (which bazel && bazel clean) || true; | ||
| . ./ci/ci.sh init && source ~/.zshenv | ||
| source ~/.zshrc | ||
| ./ci/ci.sh build | ||
| ./ci/env/env_info.sh |
There was a problem hiding this comment.
could you put prelude and epilogue in two bash functions too? maybe with name starting with _?
ci/ray_ci/macos/macos_ci.sh
Outdated
|
|
||
| $1 | ||
|
|
||
| #epilogue |
There was a problem hiding this comment.
should this be put in a trap to make sure it runs?
can-anyscale
force-pushed
the
can-mac01
branch
from
0f27162
to
11fdc26
Compare
Signed-off-by: can <[email protected]>
can-anyscale
force-pushed
the
can-mac01
branch
from
11fdc26
to
c5dd4c6
Compare
|
Address @aslonnie's comments |
aslonnie
approved these changes
Jan 3, 2024
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
Jan 12, 2024
Move as it is. Note that the test //python/ray/tests:test_actor_client_mode is failing on this PR and is also failing on master Signed-off-by: can <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move as it is. Note that the test
//python/ray/tests:test_actor_client_modeis failing on this PR and is also failing on masterTest: