[serve] Refactor RayServeWrappedReplica to not be dynamically generated
#42014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
| self._replica_tag = replica_tag | ||
| deployment_config = DeploymentConfig.from_proto_bytes( | ||
| deployment_config_proto_bytes | ||
| class RayServeWrappedReplica: |
There was a problem hiding this comment.
Could you add a docstring explaining what this class does?
|
|
||
| init_args = cloudpickle.loads(serialized_init_args) | ||
| init_kwargs = cloudpickle.loads(serialized_init_kwargs) | ||
| # Set the controller name so that serve.connect() in the user's |
There was a problem hiding this comment.
Could you update this comment?serve.connect() no longer exists.
| self._replica_tag = replica_tag | ||
| deployment_config = DeploymentConfig.from_proto_bytes( | ||
| deployment_config_proto_bytes | ||
| class RayServeWrappedReplica: |
There was a problem hiding this comment.
I assume everything in this class is a pure move?
shrekris-anyscale
approved these changes
Dec 19, 2023
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
Jan 12, 2024
…ated (ray-project#42014) * fix Signed-off-by: Edward Oakes <[email protected]> * oops Signed-off-by: Edward Oakes <[email protected]> --------- Signed-off-by: Edward Oakes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This is a relic of a long time ago when this needed to be generated by a function. The excessive nesting makes reading the quote unnecessarily hard.
There are a lot of LOC changed here, but all I did was:
RayServeWrappedReplicato the top level inreplica.py.RayServeWrappedReplicadirectly todeployment_info.pyinstead of importingcreate_replica_wrapper.constants.py.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.