Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data][train] Fix air_benchmark_xgboost_cpu_10 #41957

Merged
merged 6 commits into from
Dec 16, 2023

Conversation

raulchen
Copy link
Contributor

Why are these changes needed?

air_benchmark_xgboost_cpu_10 is failing because actor pool autoscaling strategy is problematic and it makes data ingestion too slow. Changing to fixed sized actor pool to fix this issue.

The autoscaling issue will be fixed later, as it's not a commonly used feature. #41956

Related issue number

Closes #41859

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Hao Chen <[email protected]>
Signed-off-by: Hao Chen <[email protected]>
@raulchen raulchen merged commit 87af9a3 into ray-project:master Dec 16, 2023
5 of 9 checks passed
@raulchen raulchen deleted the fix-xgboost-benchmark branch December 16, 2023 00:50
raulchen added a commit to raulchen/ray that referenced this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release test air_benchmark_xgboost_cpu_10.aws failed
2 participants