Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve][Doc] Triton server integration #41923

Merged
merged 10 commits into from
Jan 23, 2024

Conversation

sihanwang41
Copy link
Contributor

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

This guide shows how to serve models with [NVIDIA Triton Server](https://github.com/triton-inference-server/server) using Ray Serve.

## Installation
Here is the Dockerfile example for installing Triton Server with Ray Serve.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait for dockerfile from nvidia.

Signed-off-by: Sihan Wang <[email protected]>
@edoakes
Copy link
Contributor

edoakes commented Dec 14, 2023

Ping me when ready for review

Signed-off-by: Sihan Wang <[email protected]>
@sihanwang41
Copy link
Contributor Author

Ping me when ready for review

Sounds good, let me know if you think anything needed to be added. The major thing waiting from nvidia is Dockerfile part.

@sihanwang41 sihanwang41 changed the title [WIP][Serve][Doc] Triton server integration [Serve][Doc] Triton server integration Jan 21, 2024
Signed-off-by: Sihan Wang <[email protected]>
Signed-off-by: Sihan Wang <[email protected]>
Signed-off-by: Sihan Wang <[email protected]>
@sihanwang41
Copy link
Contributor Author

@akshay-anyscale PTAL



## Start Ray Serve with the Triton Server
Triton Server provides python API to start the Triton Server instance. You can use the `nvcr.io/nvidia/tritonserver:23.12-py3` image which already have the Triton Server python API library installed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the complete instructions for how to build an image that has both triton and ray?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Signed-off-by: Sihan Wang <[email protected]>
@sihanwang41
Copy link
Contributor Author

Hi @edoakes, the pr is updated, PTAL.

Copy link
Contributor

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just nits

doc/source/serve/tutorials/triton-server-integration.md Outdated Show resolved Hide resolved
doc/source/serve/tutorials/triton-server-integration.md Outdated Show resolved Hide resolved
doc/source/serve/tutorials/triton-server-integration.md Outdated Show resolved Hide resolved
doc/source/serve/tutorials/triton-server-integration.md Outdated Show resolved Hide resolved
doc/source/serve/tutorials/triton-server-integration.md Outdated Show resolved Hide resolved
doc/source/serve/tutorials/triton-server-integration.md Outdated Show resolved Hide resolved
doc/source/serve/tutorials/triton-server-integration.md Outdated Show resolved Hide resolved
doc/source/serve/tutorials/triton-server-integration.md Outdated Show resolved Hide resolved
Signed-off-by: Sihan Wang <[email protected]>
@edoakes edoakes merged commit 1870a17 into ray-project:master Jan 23, 2024
9 checks passed
sihanwang41 added a commit to sihanwang41/ray that referenced this pull request Jan 24, 2024
@sihanwang41 sihanwang41 mentioned this pull request Jan 24, 2024
8 tasks
architkulkarni pushed a commit that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants