Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary test file in wheel #41775

Merged
merged 8 commits into from
Dec 12, 2023
Merged

Conversation

fishbone
Copy link
Contributor

Why are these changes needed?

This PR remove the test file in pip wheel which lead to the ray start failed

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@fishbone
Copy link
Contributor Author

Some test might fail. I'll update them. Waiting for test.

@fishbone
Copy link
Contributor Author

Seems ok now. The rest failure is because of the trunk failure.

@fishbone
Copy link
Contributor Author

Some test still failed. Looking into it.

@fishbone fishbone merged commit 1716b79 into ray-project:master Dec 12, 2023
12 of 14 checks passed
fishbone added a commit to fishbone/ray that referenced this pull request Dec 12, 2023
This PR remove the test file in pip wheel which lead to the ray start failed
architkulkarni pushed a commit that referenced this pull request Dec 12, 2023
This PR remove the test file in pip wheel which lead to the ray start failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] Command ray start --head reports missing module async_timeout
3 participants