[Data] Check if BigQuery dataset exists before creation #41630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cheng Su <[email protected]>
|
Hi @matthew29tang, can you help take a look of this PR? Thanks! |
matthew29tang
suggested changes
Dec 5, 2023
| logger.info( | ||
| f"Dataset {dataset_id} already exists. " | ||
| "The table will be overwritten if it already exists." | ||
| ) | ||
| except NotFound: |
There was a problem hiding this comment.
You can just do except exceptions.NotFound to use the existing import from google.api_core import exceptions, similar to the BigQuery read
Signed-off-by: Cheng Su <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We found issue that user may not grant permission to create Google BigQuery dataset when using Ray Data
write_bigquery()API. So theclient.create_datasetcall would fail with permission error:So here we change to check if BigQuery dataset already exists, if not then trying to create it.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.