[Data] Fix doc for read_json #41240
Merged
[Data] Fix doc for read_json #41240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cheng Su <[email protected]>
c21
requested review from
ericl,
scv119,
amogkam,
scottjlee,
bveeramani,
raulchen,
stephanie-wang and
Zandew
as code owners
aslonnie
reviewed
Nov 20, 2023
python/ray/data/read_api.py
Outdated
| @@ -1044,7 +1044,11 @@ def read_json( | |||
| ... "s3:https://anonymous@ray-example-data/log.json", | |||
| ... read_options=pajson.ReadOptions(block_size=block_size) | |||
| ... ) | |||
| Dataset(num_blocks=8, num_rows=1, schema={timestamp: timestamp[s], size: int64}) | |||
| Dataset( | |||
| num_blocks=..., | |||
There was a problem hiding this comment.
this does not work. sometimes it is in one line, and sometimes in multiple lines.
rather than printing the entire Dataset out, maybe just print out the num_rows and schema? and assert num_blocks?
or is there some way to force the environment to treat num_blocks to be a constant, and not dependent on environment?
There was a problem hiding this comment.
Yeah noticed that, will skip doc test in this case. In the future, we would always print out Dataset in multiple lines.
Signed-off-by: Cheng Su <[email protected]>
aslonnie
approved these changes
Nov 21, 2023
|
Yeah let's get approval and merge tomorrow. |
bveeramani
requested changes
Nov 21, 2023
Co-authored-by: Balaji Veeramani <[email protected]> Signed-off-by: Cheng Su <[email protected]>
raulchen
approved these changes
Nov 22, 2023
bveeramani
approved these changes
Nov 22, 2023
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Nov 29, 2023
To avoid test becomes flaky that num_blocks can be different in different test infra. Signed-off-by: Cheng Su <[email protected]> Co-authored-by: Balaji Veeramani <[email protected]> Co-authored-by: Balaji Veeramani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
To avoid test becomes flaky that num_blocks can be different in different test infra.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.