[CI] [Cluster] Fix example GCP GPU/docker example cluster YAML file #41134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
The release test passed.
|
|
Linkcheck failure is unrelated, this PR doesn't touch the docs. |
architkulkarni
added
the
tests-ok
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Nov 29, 2023
…ay-project#41134) Fixes the broken GCP GPU docker example YAML by updating the image and cuda version. (Thanks @PaulFenton for the fix!) Adds a release test that checks that ray up works with this YAML file (it didn't work before). Switched the image used in the YAML to ray instead of ray-ml because ray-ml gave errors with running out of disk space, and because it makes the test run faster. If it's important to make ray-ml the default, we can probably just increase diskSizeGb and test it again. Related issue number Closes ray-project#35266 --------- Signed-off-by: Archit Kulkarni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Fixes the broken GCP GPU docker example YAML by updating the image and cuda version. (Thanks @PaulFenton for the fix!)
Adds a release test that checks that
ray upworks with this YAML file (it didn't work before).Switched the image used in the YAML to
rayinstead ofray-mlbecauseray-mlgave errors with running out of disk space, and because it makes the test run faster. If it's important to makeray-mlthe default, we can probably just increasediskSizeGband test it again.Related issue number
Closes #35266
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.