-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] [Clusters] Add missing steps and simplify YAML in top-level clusters quickstart #41131
Merged
architkulkarni
merged 22 commits into
ray-project:master
from
architkulkarni:fix-getting-started-clusters
Nov 21, 2023
Merged
[Doc] [Clusters] Add missing steps and simplify YAML in top-level clusters quickstart #41131
architkulkarni
merged 22 commits into
ray-project:master
from
architkulkarni:fix-getting-started-clusters
Nov 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
rynewang
approved these changes
Nov 15, 2023
# For more documentation on available fields, see: | ||
# http:https://boto3.readthedocs.io/en/latest/reference/services/ec2.html#EC2.ServiceResource.create_instances | ||
node_config: | ||
InstanceType: m5.large |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newline?
jjyao
approved these changes
Nov 15, 2023
angelinalg
approved these changes
Nov 20, 2023
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Archit Kulkarni <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Archit Kulkarni <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Archit Kulkarni <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Archit Kulkarni <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Archit Kulkarni <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Archit Kulkarni <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Archit Kulkarni <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Archit Kulkarni <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Archit Kulkarni <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Archit Kulkarni <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Archit Kulkarni <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Archit Kulkarni <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Archit Kulkarni <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
…hitkulkarni/ray into fix-getting-started-clusters Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
The script passed:
|
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Nov 29, 2023
…sters quickstart (ray-project#41131) Closes ray-project#35299 by adding missing steps and using a minimal cluster YAML file. Addresses ray-project#33026 for the AWS example-minimal.yaml by adding min_workers, max_workers and the instance type. The issue will remain open until it's fixed for all the other cluster provider example-minimal YAML files as well. --------- Signed-off-by: Archit Kulkarni <[email protected]> Signed-off-by: Archit Kulkarni <[email protected]> Co-authored-by: angelinalg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Closes #35299 by adding missing steps and using a minimal cluster YAML file.
Addresses #33026 for the AWS example-minimal.yaml by adding min_workers, max_workers and the instance type. The issue will remain open until it's fixed for all the other cluster provider example-minimal YAML files as well.
I'll run through the final tutorial manually once before merging.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.