Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serve] Add piping to set and fetch target_capacity #41007

Merged
merged 6 commits into from
Nov 7, 2023

Conversation

edoakes
Copy link
Contributor

@edoakes edoakes commented Nov 7, 2023

Why are these changes needed?

Add logic to set & get target_capacity via REST API

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
@edoakes edoakes changed the title [serve] Add piping to set and fetch target_capacity [WIP][serve] Add piping to set and fetch target_capacity Nov 7, 2023
@edoakes edoakes changed the title [WIP][serve] Add piping to set and fetch target_capacity [serve] Add piping to set and fetch target_capacity Nov 7, 2023
Copy link
Contributor

@shrekris-anyscale shrekris-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -196,7 +196,10 @@ async def __init__(
self._create_control_loop_metrics()
run_background_task(self.run_control_loop())

# The target capacity percentage for all replicas across the cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# The target capacity percentage for all replicas across the cluster.
# The target capacity percentage for all deployments across the cluster.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will fix in next one

@edoakes edoakes merged commit cc93df5 into ray-project:master Nov 7, 2023
13 of 24 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
)

Add logic to set & get target_capacity via REST API

---------

Signed-off-by: Edward Oakes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants