Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Deflaky test_basic_5_client_mode #40989

Merged
merged 10 commits into from
Nov 14, 2023
Merged

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Nov 6, 2023

Why are these changes needed?

When testing jemalloc + ray client, we are observing occasional dead lock and issues from grpc library from both CI and in my local dev:
image

Might still be related to grpc/grpc#31885

Moving the jemalloc test out of ray client as I don't think we expect ray client to work with such.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: rickyyx <[email protected]>
Signed-off-by: rickyyx <[email protected]>
Signed-off-by: rickyyx <[email protected]>
Signed-off-by: rickyyx <[email protected]>
@rickyyx rickyyx changed the title [ci] try clean up [ci] Deflaky test_basic_5_client_mode Nov 8, 2023
@rickyyx rickyyx merged commit 7a19262 into ray-project:master Nov 14, 2023
18 of 21 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants