[ci] move data integration tests to civ2 #40658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can-anyscale
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
bveeramani,
raulchen,
stephanie-wang,
Zandew and
aslonnie
as code owners
can-anyscale
force-pushed
the
can-data-01
branch
from
7a76738
to
7d13ba5
Compare
can-anyscale
commented
Oct 25, 2023
ci/docker/base.ml.Dockerfile
Outdated
| @@ -3,6 +3,8 @@ FROM $DOCKER_IMAGE_BASE_TEST | |||
|
|
|||
| COPY . . | |||
|
|
|||
| RUN apt-get install -y -qq maven openjdk-8-jre openjdk-8-jdk | |||
There was a problem hiding this comment.
need this to build java
There was a problem hiding this comment.
how much size will this add? I recall that the size of maven and jdk is non-trivial actually. should we consider split java required stuff into another base? (we can reuse this build file)
There was a problem hiding this comment.
I can make it so that we install this only for the data.mongodb build. There is only one data test requires java to be installed.
can-anyscale
force-pushed
the
can-data-01
branch
from
7d13ba5
to
85dbe6f
Compare
|
CC: @c21 , @scottjlee , @raulchen if you can help review the changes to python/ray/data/tests/test_mongo.py i would appreciate, thankks |
aslonnie
reviewed
Oct 26, 2023
can-anyscale
force-pushed
the
can-data-01
branch
from
85dbe6f
to
882beb4
Compare
Signed-off-by: can <[email protected]>
can-anyscale
force-pushed
the
can-data-01
branch
from
882beb4
to
7940311
Compare
aslonnie
approved these changes
Oct 26, 2023
raulchen
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test: