Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deflakey] Deflakey test_actor_advanced.py #40636

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

fishbone
Copy link
Contributor

Signed-off-by: Yi Cheng [email protected]

Why are these changes needed?

The test failure is caused by the timing issues. This PR removed the timing check. The regression should be caught by other dashboard.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Yi Cheng <[email protected]>
@fishbone fishbone merged commit fc98a5f into ray-project:master Oct 24, 2023
30 of 37 checks passed
@rickyyx rickyyx mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] linux:https://python/ray/tests:test_actor_advanced is failing/flaky on master.
3 participants