Remove numpy for Ray wheel build #40603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philipp Moritz <[email protected]>
|
Sorry I missed this for too long now that it has conflicts, this looks valid, @pcmoritz do you want to rebase and merge this |
Signed-off-by: Philipp Moritz <[email protected]>
|
Yeah, let's merge it if the tests pass :) |
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
Jan 12, 2024
I don't think this is actually needed any more since Ray doesn't depend on numpy any more (it used to be that some of Ray's serialization code did, but that's not the case any more). Follow up from ray-project#40399 Signed-off-by: Philipp Moritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
I don't think this is actually needed any more since Ray doesn't depend on numpy any more (it used to be that some of Ray's serialization code did, but that's not the case any more).
Follow up from #40399
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.