Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] [cluster launcher] Fix switched "latest" and "nightly" gcp tests #40453

Merged
merged 7 commits into from
Oct 20, 2023
Merged

[CI] [cluster launcher] Fix switched "latest" and "nightly" gcp tests #40453

merged 7 commits into from
Oct 20, 2023

Conversation

architkulkarni
Copy link
Contributor

@architkulkarni architkulkarni commented Oct 18, 2023 •
edited
Loading

Why are these changes needed?

The GCP "latest" and "nightly" tests had their names switched. This PR unswitches them.

The PR also adds more debug logs for the issue #40241.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@architkulkarni architkulkarni marked this pull request as ready for review October 18, 2023 21:20
@architkulkarni architkulkarni requested review from ericl and a team as code owners October 18, 2023 21:20
@architkulkarni architkulkarni mentioned this pull request Oct 19, 2023
Closed
@architkulkarni architkulkarni linked an issue Oct 19, 2023 that may be closed by this pull request
Release test gcp_cluster_launcher_latest_image failed #40241
Closed
@architkulkarni
Copy link
Contributor Author

Chaos test, doc test, rllib test unrelated. k8s test failure unrelated (it fails at the step of kubectl delete)

@architkulkarni architkulkarni added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Oct 20, 2023
@architkulkarni architkulkarni merged commit e615eaf into ray-project:master Oct 20, 2023
45 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scv119 scv119 scv119 approved these changes

@ericl ericl Awaiting requested review from ericl ericl is a code owner

Assignees

@scv119 scv119

@can-anyscale can-anyscale

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release test gcp_cluster_launcher_latest_image failed
3 participants
@architkulkarni @scv119 @can-anyscale