[ci] move rllib small-gpu tests to civ2 #40439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can-anyscale
force-pushed
the
can-ci-09
branch
3 times, most recently
from
653e0fb
to
248b1b9
Compare
can-anyscale
changed the title
can-anyscale
changed the title
aslonnie
reviewed
Oct 19, 2023
.buildkite/rllib.rayci.yml
Outdated
| @@ -77,6 +77,20 @@ steps: | |||
| depends_on: rllibbuild | |||
| job_env: forge | |||
|
|
|||
| - label: ":brain: rllib: gpu tests" | |||
| tags: rllib | |||
| The word boundary is escaped twice because it is used in a python string and then | ||
| used again as a string in bazel query. | ||
| """ | ||
| return f"\\\\b{tag}\\\\b" |
There was a problem hiding this comment.
could you add a unit test for this function? just to illustrate how this works?
can-anyscale
force-pushed
the
can-ci-09
branch
from
45c9909
to
c614b59
Compare
Signed-off-by: can <[email protected]>
can-anyscale
force-pushed
the
can-ci-09
branch
from
c614b59
to
f0cf299
Compare
aslonnie
approved these changes
Oct 19, 2023
| def test_get_tag_matcher() -> None: | ||
| assert re.match( | ||
| # simulate shell character escaping | ||
| bytes(_get_tag_matcher("tag"), "utf-8").decode("unicode_escape"), |
There was a problem hiding this comment.
why is this using unicode_escape?
There was a problem hiding this comment.
It evaluates the escape character in a string, for example, the string 'a\\nb' will be evaluated to 'a\nb', which is what happen to a string in a shell command
Signed-off-by: Cuong Nguyen <[email protected]>
jonathan-anyscale
pushed a commit
to jonathan-anyscale/ray
that referenced
this pull request
Oct 26, 2023
- rllib uses 'gpu' and 'multi-gpu' tag which confuses bazel query tag since it takes the input as a regex. Updated ray_ci to strictly query for an exact match of tag - we cannot parallelize this job because the machine has only one core Signed-off-by: Cuong Nguyen <[email protected]>
jonathan-anyscale
pushed a commit
to jonathan-anyscale/ray
that referenced
this pull request
Oct 26, 2023
- rllib uses 'gpu' and 'multi-gpu' tag which confuses bazel query tag since it takes the input as a regex. Updated ray_ci to strictly query for an exact match of tag - we cannot parallelize this job because the machine has only one core Signed-off-by: Cuong Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test: