Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deflakey] Deflakey test_redis_tls #40378

Merged
merged 4 commits into from
Oct 17, 2023
Merged

[deflakey] Deflakey test_redis_tls #40378

merged 4 commits into from
Oct 17, 2023

Conversation

fishbone
Copy link
Contributor

Why are these changes needed?

The test sometimes got timeout is because the key generation takes a long time. This fix just pre-generate the related files and use that to save time.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@fishbone
Copy link
Contributor Author

@fishbone
Copy link
Contributor Author





25143:M 16 Oct 2023 21:50:19.847 # Failed to load certificate: /root/.cache/bazel/_bazel_root/1df605deb6d24fc8068f6e25793ec703/execroot/com_github_ray_project_ray/bazel-out/k8-opt/bin/python/ray/tests/test_redis_tls.runfiles/com_github_ray_project_ray/python/ray/tests/tls/redis.crt: error:02001002:system library:fopen:No such file or directory
 

<br class="Apple-interchange-newline">

Different error. Seems path is not setup correctly.

@fishbone fishbone merged commit 8fa1565 into master Oct 17, 2023
72 of 80 checks passed
@fishbone fishbone deleted the deflakey-test-rls branch October 17, 2023 02:37
@fishbone fishbone mentioned this pull request Oct 17, 2023
8 tasks
fishbone added a commit that referenced this pull request Oct 18, 2023
After #40378 being merged, the test should be stable. Unjail it.
jonathan-anyscale pushed a commit to jonathan-anyscale/ray that referenced this pull request Oct 26, 2023
After ray-project#40378 being merged, the test should be stable. Unjail it.
jonathan-anyscale pushed a commit to jonathan-anyscale/ray that referenced this pull request Oct 26, 2023
After ray-project#40378 being merged, the test should be stable. Unjail it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] linux:https://python/ray/tests:test_redis_tls is failing/flaky on master.
3 participants