Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Fix documentation for union and limit #40299

Merged
merged 1 commit into from
Oct 13, 2023
Merged

[Data] Fix documentation for union and limit #40299

merged 1 commit into from
Oct 13, 2023

Conversation

c21
Copy link
Contributor

@c21 c21 commented Oct 12, 2023 •
edited
Loading

Why are these changes needed?

Given union and limit are lazy operation, we should not mark them with @ConsumptionAPI.

https://anyscale-ray--40299.com.readthedocs.build/en/40299/data/api/doc/ray.data.Dataset.union.html
https://anyscale-ray--40299.com.readthedocs.build/en/40299/data/api/doc/ray.data.Dataset.limit.html

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@c21 c21 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Oct 13, 2023
@c21 c21 merged commit 0f07950 into ray-project:master Oct 13, 2023
38 of 40 checks passed
@c21 c21 deleted the fix-limit branch October 13, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bveeramani bveeramani bveeramani approved these changes

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@scv119 scv119 Awaiting requested review from scv119 scv119 is a code owner

@amogkam amogkam Awaiting requested review from amogkam amogkam is a code owner

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

Assignees

@scottjlee scottjlee

@bveeramani bveeramani

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c21 @bveeramani @scottjlee