-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tune] New persistence mode cleanup: Trainable
, FunctionTrainable
, Tune session
#40181
Merged
justinvyu
merged 35 commits into
ray-project:master
from
justinvyu:cleanup_old_codepath_tune2
Oct 9, 2023
Merged
[tune] New persistence mode cleanup: Trainable
, FunctionTrainable
, Tune session
#40181
justinvyu
merged 35 commits into
ray-project:master
from
justinvyu:cleanup_old_codepath_tune2
Oct 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
…nup_old_codepath_tune2
…nup_old_codepath_tune2 Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
justinvyu
requested review from
sven1977,
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad,
maxpumperla,
kouroshHakha,
krfricke and
a team
as code owners
October 6, 2023 23:11
matthewdeng
approved these changes
Oct 6, 2023
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…, Tune session (ray-project#40181) This PR removes the last of the old persistence mode codepath: * The `Trainable` interface has been stripped down to just the main `save`, `restore`, `train`, etc. interfaces. All of the code relating to checkpoint and artifact uploading to cloud has been removed -- this is all handled by the `StorageContext` now. * The `FunctionTrainable` interface has been greatly simplified, and the Tune session (`_StatusReporter`) has been removed, since the `FunctionTrainable` just uses the `_TrainSession` now. --------- Signed-off-by: Justin Yu <[email protected]> Signed-off-by: Victor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR removes the last of the old persistence mode codepath:
Trainable
interface has been stripped down to just the mainsave
,restore
,train
, etc. interfaces. All of the code relating to checkpoint and artifact uploading to cloud has been removed -- this is all handled by theStorageContext
now.FunctionTrainable
interface has been greatly simplified, and the Tune session (_StatusReporter
) has been removed, since theFunctionTrainable
just uses the_TrainSession
now.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.