-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cluster launcher] Add more commands to "Useful commands" CLI output #40160
[Cluster launcher] Add more commands to "Useful commands" CLI output #40160
Conversation
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Yes. That makes sense. We need a better solution here. It's really confusing. Can we create an issue to track it? cc: @jjyao
Sorry. What did you fix? It seems that this was the same issues as the one above.
Got it. Thanks! |
I will create an issue and link it here.
I was referring to this commit: 18398de So for this command, the screenshot in the description is slightly out of date (it predates this commit). Basically, it is correct to write "localhost" because we instructed the user to do port-forwarding first. |
@scottsun94 added the issue! #40833 |
Signed-off-by: Archit Kulkarni <[email protected]>
LGTM. Thanks! |
Signed-off-by: Archit Kulkarni <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
…tkulkarni/ray into update-cli-useful-commands Signed-off-by: Archit Kulkarni <[email protected]>
…ay-project#40160) Updates the "useful commands" printed on ray up to add ray down ray get-head-ip ray dashboard ray job submit Removes the "manual ssh command", because "ray attach" should be used instead. In summary, this PR implements the conclusion of the discussion here: ray-project#34685 (comment) This PR also fixes a bug where cluster-name was not printed in the example commands in places where it should have been. (This is stored in the variable modifiers in the code) Related issue number Closes ray-project#34685 --------- Signed-off-by: Archit Kulkarni <[email protected]> Signed-off-by: Archit Kulkarni <[email protected]>
Why are these changes needed?
Updates the "useful commands" printed on
ray up
to addRemoves the "manual ssh command", because "ray attach" should be used instead.
In summary, this PR implements the conclusion of the discussion here: #34685 (comment)
This PR also fixes a bug where
cluster-name
was not printed in the example commands in places where it should have been. (This is stored in the variablemodifiers
in the code)Related issue number
Closes #34685
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.