Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Remove dead _sliding_window function #40134

Merged
merged 1 commit into from
Oct 5, 2023
Merged

[Data] Remove dead _sliding_window function #40134

merged 1 commit into from
Oct 5, 2023

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

dataset.py contains a _sliding_window function, but it isn't used anywhere. This PR removes it.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

scottjlee
scottjlee approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@scottjlee scottjlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bveeramani bveeramani merged commit 0747470 into ray-project:master Oct 5, 2023
41 of 44 checks passed
Zandew pushed a commit to Zandew/ray that referenced this pull request Oct 10, 2023
@bveeramani
[Data] Remove dead _sliding_window function (ray-project#40134)
cd9427e 
dataset.py contains a _sliding_window function, but it isn't used anywhere. This PR removes it.

Signed-off-by: Balaji Veeramani <[email protected]>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@bveeramani
[Data] Remove dead _sliding_window function (ray-project#40134)
322e004 
dataset.py contains a _sliding_window function, but it isn't used anywhere. This PR removes it.

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Victor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c21 c21 c21 approved these changes

@scottjlee scottjlee scottjlee approved these changes

@ericl ericl Awaiting requested review from ericl

@scv119 scv119 Awaiting requested review from scv119

@amogkam amogkam Awaiting requested review from amogkam

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

Assignees

@c21 c21

@scottjlee scottjlee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bveeramani @c21 @scottjlee