[civ2][5] move rllib fake_gpus + tf2-eager-tracing to civ2 #40031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can-anyscale
force-pushed
the
can-civ-05
branch
2 times, most recently
from
ea7e3ba
to
455c611
Compare
can-anyscale
force-pushed
the
can-civ-04
branch
from
a425efd
to
dea04e1
Compare
can-anyscale
force-pushed
the
can-civ-05
branch
from
455c611
to
0384230
Compare
can-anyscale
force-pushed
the
can-civ-04
branch
from
dea04e1
to
b315f18
Compare
can-anyscale
force-pushed
the
can-civ-05
branch
from
0384230
to
5feb929
Compare
can-anyscale
force-pushed
the
can-civ-04
branch
12 times, most recently
from
dc3c663
to
cfe1cff
Compare
can-anyscale
force-pushed
the
can-civ-05
branch
2 times, most recently
from
ff4b910
to
866b20c
Compare
can-anyscale
force-pushed
the
can-civ-04
branch
2 times, most recently
from
4c85311
to
7103881
Compare
can-anyscale
force-pushed
the
can-civ-05
branch
2 times, most recently
from
4746225
to
ea6091a
Compare
can-anyscale
commented
Oct 5, 2023
| depends_on: rllibbuild | ||
| job_env: forge | ||
|
|
||
| - label: ":brain: rllib: benchmarks" |
There was a problem hiding this comment.
move this down here, it looks nicer on the ui if things are sorted by size
can-anyscale
force-pushed
the
can-civ-04
branch
from
7103881
to
3c42751
Compare
can-anyscale
force-pushed
the
can-civ-05
branch
from
ea6091a
to
e8b96f7
Compare
Signed-off-by: can <[email protected]>
Signed-off-by: can <[email protected]>
Signed-off-by: can <[email protected]>
can-anyscale
force-pushed
the
can-civ-04
branch
from
3c42751
to
4efa4e4
Compare
can-anyscale
force-pushed
the
can-civ-05
branch
from
e8b96f7
to
f2491ac
Compare
can-anyscale
changed the title
can-anyscale
force-pushed
the
can-civ-05
branch
from
f2491ac
to
a444158
Compare
Signed-off-by: can <[email protected]>
can-anyscale
force-pushed
the
can-civ-05
branch
from
a444158
to
0bd31e1
Compare
can-anyscale
requested review from
a team,
ArturNiederfahrenhorst,
avnishn and
kouroshHakha
aslonnie
reviewed
Oct 10, 2023
| @@ -138,7 +138,6 @@ def get_commit_range(): | |||
| # End of dry run. | |||
|
|
|||
| skip_prefix_list = [ | |||
| ".buildkite/", | |||
There was a problem hiding this comment.
why is this line remove?
There was a problem hiding this comment.
Files in this list are basically skipped when determining which tests to run. Without this change, this PR does not trigger rllib tests, even though it changes the rllib.rayci.yaml file :)
aslonnie
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move rllib fake_gpus + tf2-eager-tracing to civ2. Nothing special, just move them to civ2.
Test: