Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Remove unnecessary bases #39982

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Sep 29, 2023

Why are these changes needed?

Before
image

After
image

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani requested a review from a team as a code owner September 29, 2023 18:27
@KamenShah KamenShah mentioned this pull request Sep 29, 2023
8 tasks
@peytondmurray
Copy link
Contributor

@bveeramani Does this message only appear if you explicitly subclass object? If so, we can tear out any of those instances, as it was only necessary to subclass object in Python 2.

Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the object class ever be listed in a list with multiple bases? Or is it automatically dropped if there is another base class to list?

@bveeramani
Copy link
Member Author

@bveeramani Does this message only appear if you explicitly subclass object?

No, it shows up even if you don't explicitly subclass object.

If so, we can tear out any of those instances, as it was only necessary to subclass object in Python 2.

Totally agree. I think we still have those in a handful of places.

@bveeramani
Copy link
Member Author

Would the object class ever be listed in a list with multiple bases? Or is it automatically dropped if there is another base class to list?

Don't think so unless you explicitly did something like Subclass(BaseClass, object), but that would be incredibly unusual.

Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 🚀

@bveeramani bveeramani merged commit 4b6419c into ray-project:master Oct 5, 2023
18 of 19 checks passed
Zandew pushed a commit to Zandew/ray that referenced this pull request Oct 10, 2023
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants