-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cluster launcher] Add friendly warning for missing boto3 and googleapiclient imports #39942
[Cluster launcher] Add friendly warning for missing boto3 and googleapiclient imports #39942
Conversation
Signed-off-by: Archit Kulkarni <[email protected]>
It seems the file structure has changed. I couldn't find the relevant requirements.txt file for |
No, that one doesn't have |
@can-anyscale do you happen to know where to add it? |
@architkulkarni it's that python/requirements.txt file; you can just add a new comment to create a session of [default] and add boto3 under it you might need to update the python/requirements_compiled.txt (auto-generated code) as well (https://www.notion.so/anyscale-hq/OSS-Python-dependency-management-f32633b0018c423f927727807ea9da08) |
Signed-off-by: Archit Kulkarni <[email protected]>
@can-anyscale I don't see the |
Hi, normally python/requirements.txt requires an update (documentation is wrong?), but boto3 is already in the compiled list so in this particular case you don't need to update. |
Ahh makes sense, thanks! |
@edoakes do you mind reviewing this PR as codeowner? |
@architkulkarni not sure if this has previously been discussed but I'm not sure if we want to do this; this is essentially making the AWS cluster launcher a supported part of the default installation, and opting folks into requiring this dependency even if they're running on other platforms (or not using the cluster launcher). I believe the current "policy" is that the cluster launchers are community-maintained, optional extensions to Ray. I think the better solution would be to have a separate install target for each cluster launcher variant, like |
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
…d job" This reverts commit f5941a1. Signed-off-by: Archit Kulkarni <[email protected]>
This reverts commit 4e524a8. Signed-off-by: Archit Kulkarni <[email protected]>
This reverts commit 1fd2102. Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
…botocore-requirement Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Discussed offline, we'll just add a better import warning. @edoakes please take another look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
LGTM
…piclient imports (ray-project#39942) Adds a friendlier warning when required packages for the cluster launcher are missing. boto3 in the case of AWS, and googleapiclient for GCP Related issue number Closes ray-project#39941 --------- Signed-off-by: Archit Kulkarni <[email protected]> Signed-off-by: Archit Kulkarni <[email protected]>
Why are these changes needed?
Adds a friendlier warning when required packages for the cluster launcher are missing.
boto3
in the case of AWS, andgoogleapiclient
for GCPRelated issue number
Closes #39941
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.