[ci][coverage] turn off core + serverless tests for non-core changes #39837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can-anyscale
force-pushed
the
can-civ-cov
branch
4 times, most recently
from
b2ff6ed
to
f4d3b0b
Compare
can-anyscale
changed the title
|
premerge is failing because this depends on ray-project/rayci#111; i put this up anyway to see how the other PR logic can be used in production |
can-anyscale
force-pushed
the
can-civ-cov
branch
from
f4d3b0b
to
6ce910f
Compare
aslonnie
reviewed
Sep 28, 2023
can-anyscale
force-pushed
the
can-civ-cov
branch
from
6ce910f
to
43f4780
Compare
can-anyscale
force-pushed
the
can-civ-cov
branch
from
43f4780
to
f84959d
Compare
|
changed the flag name to |
aslonnie
approved these changes
Sep 29, 2023
aslonnie
reviewed
Sep 29, 2023
There was a problem hiding this comment.
pr title seems off though. I think you need to:
- merge the python file change first
- maybe add a redirection shell script that launches the python script as a marker.
- optional: ask everyone to sync master
- merge and deploy the rayci side change, uses the shell script as the script entrance, and do nothing (and run all tests) if the command (
args[0]) does not exist. - and then enable the build/test job tags.
|
As discussed offline, this change should be backward compatible with the changes in rayci |
can-anyscale
force-pushed
the
can-civ-cov
branch
2 times, most recently
from
cf4b104
to
6525372
Compare
Signed-off-by: can <[email protected]>
can-anyscale
force-pushed
the
can-civ-cov
branch
from
6525372
to
d955883
Compare
Zandew
pushed a commit
to Zandew/ray
that referenced
this pull request
Oct 10, 2023
Compute coverage info for ray/python changes, so that we can turn off core + serverless tests for non-core changes. These tests deem to be quite flaky, and we should let core fix them without affecting other team. Signed-off-by: can <[email protected]>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
Compute coverage info for ray/python changes, so that we can turn off core + serverless tests for non-core changes. These tests deem to be quite flaky, and we should let core fix them without affecting other team. Signed-off-by: can <[email protected]> Signed-off-by: Victor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compute coverage info for ray/python changes, so that we can turn off core + serverless tests for non-core changes. These tests deem to be quite flaky, and we should let core fix them without affecting other team.
Test: