Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] DreamerV3: Issue 39751 and add module compilation tests back in. #39786

Merged
merged 6 commits into from
Sep 21, 2023
Merged

[RLlib] DreamerV3: Issue 39751 and add module compilation tests back in. #39786

merged 6 commits into from
Sep 21, 2023

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Sep 21, 2023 •
edited
Loading

DreamerV3 add module compilation tests back in and fix cont. action space bug.
Also:
Closes #39751

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
2ddb4c7 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
e0d797f 
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 changed the title [RLlib] DreamerV3 add module compilation tests back in. [RLlib] DreamerV3: Issue 39751 and add module compilation tests back in. Sep 21, 2023
@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Sep 21, 2023
@sven1977 sven1977 merged commit 82badad into ray-project:master Sep 21, 2023
31 of 41 checks passed
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Sep 26, 2023
@sven1977 @simonsays1980
[RLlib] DreamerV3: Issue 39751 and add module compilation tests back …
cd7b0f1 
…in. (ray-project#39786)

Signed-off-by: Simon Zehnder <[email protected]>
This was referenced Oct 4, 2023
Closed
Merged
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@sven1977
[RLlib] DreamerV3: Issue 39751 and add module compilation tests back …
b4a93ad 
…in. (ray-project#39786)

Signed-off-by: Victor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturNiederfahrenhorst ArturNiederfahrenhorst ArturNiederfahrenhorst approved these changes

@gjoliver gjoliver Awaiting requested review from gjoliver

@avnishn avnishn Awaiting requested review from avnishn

@smorad smorad Awaiting requested review from smorad

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@kouroshHakha kouroshHakha Awaiting requested review from kouroshHakha

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@ArturNiederfahrenhorst ArturNiederfahrenhorst

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RLlib] DreamerV3 fails on environments with continuous action spaces
2 participants
@sven1977 @ArturNiederfahrenhorst