Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][clusters] made diagrams more consistent #39713

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

angelinalg
Copy link
Contributor

Storage configuration diagrams for interactive development and production were not consistent, which had the risk of causing confusion. Feedback from @kevin85421

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: angelinalg <[email protected]>
@angelinalg angelinalg added docs An issue or change related to documentation core-clusters For launching and managing Ray clusters/jobs/kubernetes v2.7.0-pick labels Sep 16, 2023
@architkulkarni architkulkarni merged commit 6aa4ad9 into ray-project:master Sep 16, 2023
14 of 15 checks passed
@angelinalg angelinalg deleted the kuberay-diagrams branch September 17, 2023 04:37
angelinalg added a commit to angelinalg/ray that referenced this pull request Sep 17, 2023
Storage configuration diagrams for interactive development and production were not consistent, which had the risk of causing confusion. Feedback from @kevin85421

Signed-off-by: angelinalg <[email protected]>
GeneDer pushed a commit that referenced this pull request Sep 17, 2023
…ition model doc for serve (#39718)

* [docs][serve] Model Composition Guide: fixed references to line numbers and made style fixes (#39653)

Fixed some line references and passive voice.

Why are these changes needed?
Improve usability and readability.
---------

Signed-off-by: angelinalg <[email protected]>

* [doc] [clusters] make diagrams more consistent (#39713)

Storage configuration diagrams for interactive development and production were not consistent, which had the risk of causing confusion. Feedback from @kevin85421

Signed-off-by: angelinalg <[email protected]>

---------

Signed-off-by: angelinalg <[email protected]>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
Storage configuration diagrams for interactive development and production were not consistent, which had the risk of causing confusion. Feedback from @kevin85421

Signed-off-by: angelinalg <[email protected]>
Signed-off-by: Victor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-clusters For launching and managing Ray clusters/jobs/kubernetes docs An issue or change related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants