Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Increase timeout of test_ray_session_name_preserved #39667

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

jonathan-anyscale
Copy link
Contributor

@jonathan-anyscale jonathan-anyscale commented Sep 14, 2023

Why are these changes needed?

Increase timeout and the test will pass

Related issue number

Closes #39304

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jonathan Nitisastro <[email protected]>
Signed-off-by: Jonathan Nitisastro <[email protected]>
@jonathan-anyscale jonathan-anyscale marked this pull request as ready for review September 14, 2023 22:32
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it passes 5 times in a row, it lgtm

@jonathan-anyscale
Copy link
Contributor Author

if it passes 5 times in a row, it lgtm

Tried and failed several times (Either Flaky or Failed all) so on-hold for now

@jonathan-anyscale jonathan-anyscale marked this pull request as draft September 15, 2023 21:58
Signed-off-by: Jonathan Nitisastro <[email protected]>
@jonathan-anyscale jonathan-anyscale marked this pull request as ready for review September 26, 2023 16:34
@jjyao jjyao changed the title Update timeout [Test] Update timeout of test_ray_session_name_preserved Sep 26, 2023
@jjyao jjyao merged commit 413d542 into ray-project:master Sep 26, 2023
85 of 89 checks passed
@jjyao jjyao changed the title [Test] Update timeout of test_ray_session_name_preserved [Test] Increase timeout of test_ray_session_name_preserved Sep 26, 2023
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] linux:https://python/ray/tests:test_gcs_ha_e2e_2 is failing/flaky on master.
3 participants