[core] Better error handling when core_worker missing for recording logs

[rickyyx]

Why are these changes needed?

#37758

Related issue number

Closes #37758

Checks

• I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
• I've run scripts/format.sh to lint the changes in this PR.
• I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've added any new APIs to the API Reference. For example, if I added a
    method in Tune, I've added it in doc/source/tune/api/ under the
    corresponding .rst file.
• I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
• Testing Strategy
  • Unit tests
  • Release tests
  • This PR is not tested :(

[rkooo567]

LGTM. I think we should make self.core_worker to be a property instead in the longer term...

[rickyyx]

LGTM. I think we should make self.core_worker to be a property instead in the longer term...

I tried in this PR actually - i think it's not a huge improvement, instead of calling if hasattr(workrer, "core_worker") we will do if worker.core_worker

[rkooo567]

I think the property could just raise an exception instead?

[rickyyx]

I think the property could just raise an exception instead?

Then it will be similar with current approach right? When an attribute of core_worker not found, it will also just raise an exception.

[rkooo567]

Then it will be similar with current approach right? When an attribute of core_worker not found, it will also just raise an exception.

Yeah it is .But we don't need to write if not hasattr(self, "core_worker"): everywhere?

[rickyyx]

Then it will be similar with current approach right? When an attribute of core_worker not found, it will also just raise an exception.

Yeah it is .But we don't need to write if not hasattr(self, "core_worker"): everywhere?

I guess we could always don't check the existence of the attribute and let it raise exception.