Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serve] rename http spcific classes and files to be generic #39651

Merged
merged 21 commits into from
Sep 25, 2023
Merged

[serve] rename http spcific classes and files to be generic #39651

merged 21 commits into from
Sep 25, 2023

Conversation

GeneDer
Copy link
Contributor

@GeneDer GeneDer commented Sep 13, 2023 •
edited
Loading

Why are these changes needed?

Rename all HTTP specific classes and files to be generic

Related issue number

Closes: #38750

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@GeneDer
[serve] rename http spcific classes and files to be generic
a99f0dd 
Signed-off-by: Gene Su <[email protected]>
@GeneDer
WIP: rename more things
f24955d 
Signed-off-by: Gene Su <[email protected]>
@GeneDer
WIP
5a6f2f6 
Signed-off-by: Gene Su <[email protected]>
@GeneDer
Merge branch 'master' into rename-http-specific-files-and-classes
1bae0d7 
Signed-off-by: Gene Su <[email protected]>
@GeneDer
WIP: fix more names
b3302e7 
Signed-off-by: Gene Su <[email protected]>
@GeneDer
fix import
e6dde15 
Signed-off-by: Gene Su <[email protected]>
@GeneDer
Merge branch 'master' into rename-http-specific-files-and-classes
8c06785 
Signed-off-by: Gene Su <[email protected]>
@GeneDer
fix merge conflicit
0b81806 
Signed-off-by: Gene Su <[email protected]>
@GeneDer
fix more merge conflicit
c2df95b 
Signed-off-by: Gene Su <[email protected]>
@GeneDer
fix flags
1382aa7 
Signed-off-by: Gene Su <[email protected]>
@GeneDer
Merge branch 'master' into rename-http-specific-files-and-classes
17ad1ac
@GeneDer
fix patch
b47243d 
Signed-off-by: Gene Su <[email protected]>
@GeneDer
rename dashboard releated classes as well
fb143ee 
Signed-off-by: Gene Su <[email protected]>
@GeneDer
linting
76d58ae 
Signed-off-by: Gene Su <[email protected]>
@GeneDer
Merge branch 'master' into rename-http-specific-files-and-classes
d8d52dd 
Signed-off-by: Gene Su <[email protected]>
@GeneDer
Merge branch 'master' into rename-http-specific-files-and-classes
c7ba5fe
@GeneDer
Merge branch 'master' into rename-http-specific-files-and-classes
fe072a8 
Signed-off-by: Gene Der Su <[email protected]>
@GeneDer GeneDer marked this pull request as ready for review September 21, 2023 23:26
@zcin
Copy link
Contributor

zcin commented Sep 22, 2023

When I changed http_proxies -> proxies in schema.py, I forgot to modify the description: https://github.com/ray-project/ray/blob/master/python/ray/serve/schema.py#L902. Could you include a fix in this PR @GeneDer?

GeneDer and others added 2 commits September 22, 2023 10:44
@GeneDer @zcin
Update doc/source/cluster/kubernetes/troubleshooting/rayservice-troub…
a4ace51 
…leshooting.md

Co-authored-by: Cindy Zhang <[email protected]>
Signed-off-by: Gene Der Su <[email protected]>
@GeneDer
fix proxies description
1032d97 
Signed-off-by: Gene Su <[email protected]>
edoakes
edoakes approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! :)

architkulkarni
architkulkarni approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@architkulkarni architkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@edoakes edoakes merged commit d69d397 into ray-project:master Sep 25, 2023
35 of 36 checks passed
@GeneDer GeneDer deleted the rename-http-specific-files-and-classes branch September 25, 2023 20:12
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Sep 26, 2023
@GeneDer @zcin @simonsays1980
[serve] rename http spcific classes and files to be generic (ray-proj…
138f63a 
…ect#39651)

Rename all HTTP specific classes and files to be generic

Co-authored-by: Cindy Zhang <[email protected]>
Signed-off-by: Simon Zehnder <[email protected]>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@GeneDer @zcin
[serve] rename http spcific classes and files to be generic (ray-proj…
7356a03 
…ect#39651)

Rename all HTTP specific classes and files to be generic

Co-authored-by: Cindy Zhang <[email protected]>
Signed-off-by: Victor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@architkulkarni architkulkarni architkulkarni approved these changes

@edoakes edoakes edoakes approved these changes

@zcin zcin zcin approved these changes

@shrekris-anyscale shrekris-anyscale Awaiting requested review from shrekris-anyscale shrekris-anyscale is a code owner

@sihanwang41 sihanwang41 Awaiting requested review from sihanwang41

@wuisawesome wuisawesome Awaiting requested review from wuisawesome

@DmitriGekhtman DmitriGekhtman Awaiting requested review from DmitriGekhtman

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

@kevin85421 kevin85421 Awaiting requested review from kevin85421 kevin85421 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Serve] Rename HTTPState, HTTPProxyActor, and related code
4 participants
@GeneDer @zcin @architkulkarni @edoakes