[Doc] Fix Title of the Transformers GLUE example #39605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: woshiyyya <[email protected]>
Signed-off-by: woshiyyya <[email protected]>
Signed-off-by: woshiyyya <[email protected]>
woshiyyya
requested review from
richardliaw,
krfricke,
xwjiang2010,
amogkam,
matthewdeng,
Yard1,
maxpumperla and
a team
as code owners
krfricke
reviewed
Sep 12, 2023
python/ray/train/examples/accelerate/accelerate_torch_trainer_no_raydata.py
Outdated
Show resolved
Hide resolved
| @@ -19,6 +19,7 @@ | |||
| set_seed, | |||
| ) | |||
|
|
|||
| import ray.data | |||
There was a problem hiding this comment.
Does the example not work without this?
There was a problem hiding this comment.
Ray Data has a lazy import defined here, but I've never really understood if this should be something done by all libraries, no libraries, or some libraries.
There was a problem hiding this comment.
I've tried that after we import ray.train, we can freely call any methods of ray.data. Probably because we imported ray data in ray train.
There was a problem hiding this comment.
Ray Data can be accessed after import ray directly. Examples here
There was a problem hiding this comment.
oh that makes sense now. Ray train import ray, then ray.data is lazily imported.
matthewdeng
approved these changes
Sep 12, 2023
Signed-off-by: woshiyyya <[email protected]>
Signed-off-by: woshiyyya <[email protected]>
angelinalg
pushed a commit
to angelinalg/ray
that referenced
this pull request
Sep 14, 2023
Signed-off-by: woshiyyya <[email protected]>
8 tasks
GeneDer
pushed a commit
that referenced
this pull request
Sep 14, 2023
* [Doc] Fix Title of the Transformers GLUE example (#39605) Signed-off-by: woshiyyya <[email protected]> * [docs][train]Make Train example titles, heading more consistent (#39606) Signed-off-by: angelinalg <[email protected]> Co-authored-by: Yunxuan Xiao <[email protected]> Co-authored-by: matthewdeng <[email protected]> * [docs][clusters] Change title of RayService doc to Deploy Ray Serve Apps (#39641) Signed-off-by: angelinalg <[email protected]> --------- Signed-off-by: woshiyyya <[email protected]> Signed-off-by: angelinalg <[email protected]> Co-authored-by: Yunxuan Xiao <[email protected]> Co-authored-by: Yunxuan Xiao <[email protected]> Co-authored-by: matthewdeng <[email protected]>
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Sep 15, 2023
Signed-off-by: woshiyyya <[email protected]>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
Signed-off-by: woshiyyya <[email protected]> Signed-off-by: Victor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Fix the title of the GLUE example, also added missing
ray.dataimports.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.