[Core] Downgrade grpc from 1.57.0 to 1.50.2 #39575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiajun Yao <[email protected]>
8 tasks
rkooo567
approved these changes
Sep 13, 2023
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Sep 15, 2023
ray-project#39419 upgraded grpc, absl and protobuf to fix a memory leak but it turned out to have perf regression. GRPC 1.50.2, protobuf 21.6, absl 2022062.1 have the memory leak but no perf regression so we downgrade to these versions. All the changes we made to upgrade to 1.57.0 are still needed. Signed-off-by: Simon Zehnder <[email protected]>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
ray-project#39419 upgraded grpc, absl and protobuf to fix a memory leak but it turned out to have perf regression. GRPC 1.50.2, protobuf 21.6, absl 2022062.1 have the memory leak but no perf regression so we downgrade to these versions. All the changes we made to upgrade to 1.57.0 are still needed. Signed-off-by: Victor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#39419 upgraded grpc, absl and protobuf to fix a memory leak but it turned out to have perf regression.
GRPC 1.50.2, protobuf 21.6, absl 2022062.1 have the memory leak but no perf regression so we downgrade to these versions.
All the changes we made to upgrade to 1.57.0 are still needed.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.