Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core][Observability]Java worker adds job_id and state filters for "get all actor info" api #39574

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

larrylian
Copy link
Contributor

@larrylian larrylian commented Sep 12, 2023

Why are these changes needed?

  1. We both have many jobs in a ray cluster, so a job's manager role want to get this job's actors. Use ray.state.actors to fetching all actors in the cluster can lead to performance degradation.
  2. We only want to get alive actors
  3. Python already supports it, now sync to the Java worker.

Java get actors info by job id and state.

    // Filtered by job id
    JobId jobId = Ray.getRuntimeContext().getCurrentJobId();
    actorInfo = Ray.getRuntimeContext().getAllActorInfo(jobId, null);
    Assert.assertEquals(actorInfo.size(), 5);

    // Filtered by actor sate
    actorInfo = Ray.getRuntimeContext().getAllActorInfo(null, ActorState.ALIVE);
    Assert.assertEquals(actorInfo.size(), 5);

Related issue number

[Core] [Observability]Add job_id and state filters for "get all actor info" api #39245

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@SongGuyang SongGuyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SongGuyang SongGuyang self-assigned this Sep 14, 2023
@SongGuyang
Copy link
Contributor

@larrylian The Java test was failed.

@SongGuyang SongGuyang merged commit 515fbe8 into ray-project:master Sep 15, 2023
101 of 108 checks passed
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants