Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[runtime_env] Remote whl support #39407
[runtime_env] Remote whl support #39407
Changes from 1 commit
7ada563
07e0ab2
5a5eab0
04626c5
3f328a0
92a2fcf
01361a3
0b7f815
4e13ca5
7dfe1c9
c5e6c38
7c4657b
82f3666
9ead0f6
0ae714a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this cause conflict since we only use the filename of whl instead of the entire uri? Like if I have both
s3:https://A/package.whl
ands3:https://B/package.whl
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine since whl filename is uniquely generated when we create it. The only conflict is when the user want to use package with same name which is unlikely.
Also, this filename will only used to save locally, which the file will be deleted after installation so shouldn't be any conflict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we move to here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially I thought
working_dir
will support remote wheel as well but it isn't by our definition of working_dir.But this function is generally used to install wheel package, so might as well move it outside from
py_modules
for general usage later.