Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][state] Deflake test_state_api filter issues #39232

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Sep 2, 2023

Why are these changes needed?

We will skip filtering on sources for names (which needs to be case insensitive for filtering)

Related issue number

Closes #39231

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: rickyyx <[email protected]>
@rickyyx rickyyx marked this pull request as ready for review September 2, 2023 01:31
@rickyyx
Copy link
Contributor Author

rickyyx commented Sep 2, 2023

Build one passes w/o errors. https://buildkite.com/ray-project/oss-ci-build-pr/builds/34833

@rkooo567 rkooo567 merged commit 79a5643 into ray-project:master Sep 5, 2023
98 of 103 checks passed
LeonLuttenberger pushed a commit to jaidisido/ray that referenced this pull request Sep 5, 2023
harborn pushed a commit to harborn/ray that referenced this pull request Sep 8, 2023
jimthompson5802 pushed a commit to jimthompson5802/ray that referenced this pull request Sep 12, 2023
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] osx:https://python/ray/tests:test_state_api is failing/flaky on master.
2 participants