[train][ci] Fix tune_hvd_keras
import order
#39223
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The test is failing due to the ordering of
horovod
andtensorboardX.SummaryWriter
imports. This is a known issue: pytorch/pytorch#30651. This PR fixes it by moving the horovod import into the training loop -- to happen after thetensorboardX
import on the driver.The tests was passing before the
xgboost_ray
version bump, so there's probably some underlying package that got updated that's the root cause.Reproduction of the bug
Horovod first, then tensorboard fails with a segfault:
Tensorboard first then horovod works:
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.