[serve] Fix flaky test_http_state
#39184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
377aaed
to
5372256
Compare
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
edoakes
reviewed
Sep 5, 2023
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
edoakes
approved these changes
Sep 5, 2023
|
@edoakes just in case you missed this. It's ready to merge. All related tests are passing |
8 tasks
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Sep 8, 2023
Ensure `state.update` is not called at terminal states.
edoakes
pushed a commit
that referenced
this pull request
Sep 8, 2023
Re: #39184 fixes the error when calling update() from a terminal state. However, in this case, the update() on the proxy actor will no longer be called and will not meet the equality that the test is checking. This PR fix the test by checking the actual health checks count is less or equal to the expected health checks count.
jimthompson5802
pushed a commit
to jimthompson5802/ray
that referenced
this pull request
Sep 12, 2023
Ensure `state.update` is not called at terminal states. Signed-off-by: Jim Thompson <[email protected]>
jimthompson5802
pushed a commit
to jimthompson5802/ray
that referenced
this pull request
Sep 12, 2023
Re: ray-project#39184 fixes the error when calling update() from a terminal state. However, in this case, the update() on the proxy actor will no longer be called and will not meet the equality that the test is checking. This PR fix the test by checking the actual health checks count is less or equal to the expected health checks count. Signed-off-by: Jim Thompson <[email protected]>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
Ensure `state.update` is not called at terminal states. Signed-off-by: Victor <[email protected]>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
Re: ray-project#39184 fixes the error when calling update() from a terminal state. However, in this case, the update() on the proxy actor will no longer be called and will not meet the equality that the test is checking. This PR fix the test by checking the actual health checks count is less or equal to the expected health checks count. Signed-off-by: Victor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Ensure
state.updateis not called at terminal states.Related issue number
Patch https://buildkite.com/ray-project/oss-ci-build-branch/builds/5824#018a48cd-dead-40fc-82c0-547b3dab373f/6-322
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.