[Docs] Remove unnecessary testoutputs #39141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <[email protected]>
bveeramani
requested review from
richardliaw,
krfricke,
xwjiang2010,
amogkam,
matthewdeng,
Yard1,
maxpumperla,
a team,
ericl,
scv119,
c21,
scottjlee and
raulchen
as code owners
angelinalg
approved these changes
Aug 31, 2023
LeonLuttenberger
pushed a commit
to jaidisido/ray
that referenced
this pull request
Sep 5, 2023
ray-project/pytest-sphinx#5 changed our tooling to only check outputs if you provide a testoutput (previously, if you didn't provide a testoutput, then our tooling would expect your testcode to produce no output). As a follow up, this PR removes unnecessary testoutput blocks. Signed-off-by: Balaji Veeramani <[email protected]>
GeneDer
pushed a commit
to GeneDer/ray
that referenced
this pull request
Sep 6, 2023
ray-project/pytest-sphinx#5 changed our tooling to only check outputs if you provide a testoutput (previously, if you didn't provide a testoutput, then our tooling would expect your testcode to produce no output). As a follow up, this PR removes unnecessary testoutput blocks. Signed-off-by: Balaji Veeramani <[email protected]>
8 tasks
GeneDer
added a commit
that referenced
this pull request
Sep 6, 2023
ray-project/pytest-sphinx#5 changed our tooling to only check outputs if you provide a testoutput (previously, if you didn't provide a testoutput, then our tooling would expect your testcode to produce no output). As a follow up, this PR removes unnecessary testoutput blocks. Signed-off-by: Balaji Veeramani <[email protected]> Co-authored-by: Balaji Veeramani <[email protected]>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Sep 8, 2023
ray-project/pytest-sphinx#5 changed our tooling to only check outputs if you provide a testoutput (previously, if you didn't provide a testoutput, then our tooling would expect your testcode to produce no output). As a follow up, this PR removes unnecessary testoutput blocks. Signed-off-by: Balaji Veeramani <[email protected]>
jimthompson5802
pushed a commit
to jimthompson5802/ray
that referenced
this pull request
Sep 12, 2023
ray-project/pytest-sphinx#5 changed our tooling to only check outputs if you provide a testoutput (previously, if you didn't provide a testoutput, then our tooling would expect your testcode to produce no output). As a follow up, this PR removes unnecessary testoutput blocks. Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: Jim Thompson <[email protected]>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
ray-project/pytest-sphinx#5 changed our tooling to only check outputs if you provide a testoutput (previously, if you didn't provide a testoutput, then our tooling would expect your testcode to produce no output). As a follow up, this PR removes unnecessary testoutput blocks. Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: Victor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
ray-project/pytest-sphinx#5 changed our tooling to only check outputs if you provide a
testoutput(previously, if you didn't provide atestoutput, then our tooling would expect yourtestcodeto produce no output). As a follow up, this PR removes unnecessarytestoutputblocks.Related issue number
See ray-project/pytest-sphinx#5
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.