-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tune] Deprecate tune.report
, tune.checkpoint_dir
, checkpoint_dir
, and reporter
#39093
Merged
matthewdeng
merged 16 commits into
ray-project:master
from
justinvyu:deprecate_tune_report
Aug 31, 2023
Merged
[tune] Deprecate tune.report
, tune.checkpoint_dir
, checkpoint_dir
, and reporter
#39093
matthewdeng
merged 16 commits into
ray-project:master
from
justinvyu:deprecate_tune_report
Aug 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
…ecate_tune_report Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]> remainder Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
…ecate_tune_report
justinvyu
requested review from
richardliaw,
xwjiang2010,
amogkam,
Yard1,
maxpumperla and
a team
as code owners
August 30, 2023 22:30
…ecate_tune_report
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
justinvyu
requested review from
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad and
kouroshHakha
as code owners
August 31, 2023 06:17
krfricke
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice.
Are we planning to land this for 2.7?
Yep, going to pick for 2.7 |
matthewdeng
added
the
tests-ok
The tagger certifies test failures are unrelated and assumes personal liability.
label
Aug 31, 2023
matthewdeng
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really awesome, thank you for cleaning this up!
matthewdeng
pushed a commit
to matthewdeng/ray
that referenced
this pull request
Sep 1, 2023
…r`, and `reporter` (ray-project#39093) Signed-off-by: Justin Yu <[email protected]>
GeneDer
pushed a commit
that referenced
this pull request
Sep 1, 2023
…39195) * [CI] Remove tags for AIR and AIR smoke test (#39075) Signed-off-by: woshiyyya <[email protected]> * [train] New persistence mode: Finish migrating `Tune tests + examples (small)` (#39047) Signed-off-by: Justin Yu <[email protected]> * [train] Rename `train(config)` to `train_fn(config)` (#39065) Our API change from `tune.report()` to `train.report()` can lead to namespace clashes when the training function is called `train`. This has been an issue in many test migrations, including #39050 and the current failure of #38493. This PR does a global replace of all training function defined as `def train(config)` with `def train_fn(config)` to avoid future clashes. Signed-off-by: Kai Fricke <[email protected]> * [Data/Train] [Docs] Re-organize data loading performance tips (#39096) Re-organize data loading performance tips. We want the caching and the CPU nodes sections to be together since they are both addressing the same problems of optimizing performance when you have expensive CPU preprocessing, and the latter references the former. Signed-off-by: Amog Kamsetty <[email protected]> * [air] Hard deprecate PredictorDeployment and PredictorWrapper (#39108) Signed-off-by: Justin Yu <[email protected]> * Update the DeepSpeed and Accelerate doc example with new Checkpoint API. (#39014) Signed-off-by: woshiyyya <[email protected]> * [train] New persistence mode: Remove some legacy `air.Checkpoint` dependencies (#39049) Signed-off-by: Justin Yu <[email protected]> * [train] Fix wandb/comet integration API calls (#38978) Removes remaining calls to checkpoint.dir_or_data in the wandb/comet integrations Signed-off-by: Kai Fricke <[email protected]> * [tune] Deprecate `tune.report`, `tune.checkpoint_dir`, `checkpoint_dir`, and `reporter` (#39093) Signed-off-by: Justin Yu <[email protected]> * [2.7][Example] Enable new APIs for Lightning `dolly-v2-7b` Fine-tuning Example (#39117) Signed-off-by: Yunxuan Xiao <[email protected]> Co-authored-by: matthewdeng <[email protected]> * [train] New persistence mode: Re-enable py37 compatibility tests (#39121) Signed-off-by: Justin Yu <[email protected]> * [Ray 2.7 Examples][1/n] Revamp the LightningTrainer CoLA Example (#38009) Signed-off-by: Yunxuan Xiao <[email protected]> Co-authored-by: matthewdeng <[email protected]> * [train] New persistence mode: Support `chdir_to_trial_dir` functionality with `RAY_CHDIR_TO_TRIAL_DIR` env var (#39107) Signed-off-by: Justin Yu <[email protected]> * [train] New persistence mode: Minimal `BackendExecutor` cleanup (#39187) Signed-off-by: Justin Yu <[email protected]> * [train/rllib] RLlib GPU storage context tests (#39166) Signed-off-by: Kai Fricke <[email protected]> Co-authored-by: matthewdeng <[email protected]> * [docs][train] Update Train landing and Overview pages (#38808) Signed-off-by: angelinalg <[email protected]> Co-authored-by: matthewdeng <[email protected]> --------- Signed-off-by: woshiyyya <[email protected]> Signed-off-by: Justin Yu <[email protected]> Signed-off-by: Kai Fricke <[email protected]> Signed-off-by: Amog Kamsetty <[email protected]> Signed-off-by: Yunxuan Xiao <[email protected]> Signed-off-by: angelinalg <[email protected]> Co-authored-by: Yunxuan Xiao <[email protected]> Co-authored-by: Justin Yu <[email protected]> Co-authored-by: Kai Fricke <[email protected]> Co-authored-by: Amog Kamsetty <[email protected]> Co-authored-by: angelinalg <[email protected]>
LeonLuttenberger
pushed a commit
to jaidisido/ray
that referenced
this pull request
Sep 5, 2023
…r`, and `reporter` (ray-project#39093) Signed-off-by: Justin Yu <[email protected]>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Sep 8, 2023
…r`, and `reporter` (ray-project#39093) Signed-off-by: Justin Yu <[email protected]>
jimthompson5802
pushed a commit
to jimthompson5802/ray
that referenced
this pull request
Sep 12, 2023
…r`, and `reporter` (ray-project#39093) Signed-off-by: Justin Yu <[email protected]> Signed-off-by: Jim Thompson <[email protected]>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…r`, and `reporter` (ray-project#39093) Signed-off-by: Justin Yu <[email protected]> Signed-off-by: Victor <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In 2.7, we’re unifying some key APIs and implementations to be in ray.train, and this has some impact on legacy Tune APIs that have either been deprecated or not recommended for a long time.
Before 2.0, but also supported through 2.6:
API for 2.7+:
Related issue number
Closes #39035
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.