Serve Java API Improvement #38961
Merged
Serve Java API Improvement #38961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
521d345
to
45d0bcc
Compare
45d0bcc
to
9fcf0a3
Compare
9fcf0a3
to
d322507
Compare
edoakes
reviewed
Oct 2, 2023
sihanwang41
reviewed
Oct 3, 2023
There was a problem hiding this comment.
Thanks for implementing, exciting to see Java moving to 2.x API!
Can you do some auditing?
- Add docstring for public API.
- Make private API if it is not exposed to users.
- Add all v1 API with deprecate decorator. (If possible, add deprecation warning in the decorator)
java/serve/src/main/java/io/ray/serve/handle/DeploymentHandle.java
Outdated
Show resolved
Hide resolved
java/serve/src/main/java/io/ray/serve/api/ServeControllerClient.java
Outdated
Show resolved
Hide resolved
java/serve/src/main/java/io/ray/serve/api/ServeControllerClient.java
Outdated
Show resolved
Hide resolved
| * @param name application name | ||
| * @param timeoutS unit: second | ||
| */ | ||
| private void waitForApplicationRunning(String name, Long timeoutS) { |
There was a problem hiding this comment.
add check for APPLICATION_STATUS_UNHEALTHY
added 7 commits
October 7, 2023 14:02
Signed-off-by: chuhan.ly <[email protected]>
Signed-off-by: chuhan.ly <[email protected]>
Signed-off-by: chuhan.ly <[email protected]>
Signed-off-by: chuhan.ly <[email protected]>
Signed-off-by: chuhan.ly <[email protected]>
…support cross-language invocation in local mode. Signed-off-by: chuhan.ly <[email protected]>
2. Include some audit content. 3. DeploymentHandle.remote use the requestId from context. Signed-off-by: chuhan.ly <[email protected]>
bb4848c
to
fe346be
Compare
added 2 commits
October 7, 2023 23:04
Signed-off-by: chuhan.ly <[email protected]>
Signed-off-by: chuhan.ly <[email protected]>
sihanwang41
reviewed
Oct 8, 2023
sihanwang41
reviewed
Oct 9, 2023
added 4 commits
October 10, 2023 12:06
…_apps. Signed-off-by: chuhan.ly <[email protected]>
Signed-off-by: chuhan.ly <[email protected]>
Signed-off-by: chuhan.ly <[email protected]>
Signed-off-by: chuhan.ly <[email protected]>
edoakes
approved these changes
Oct 10, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This is about Serve Java Improvement. The goal of this PR is to make the Java API consistent with Python.
The design of the user API is discussed in this proposal: ray-project/enhancements#42.
This PR only covers the Java programming API part, including
Deployment.bind,Serve.run,DeploymentHandle, and so on, ensuring that these APIs can be used properly. The alignment of some internal core logic, documentation enhancements, and support for the config file will be submitted in subsequent PRs.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.