Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.7 CI][New Persistent Mode][5/n] 📖 Doc examples for external code #38915

Merged
merged 4 commits into from
Aug 27, 2023
Merged

[2.7 CI][New Persistent Mode][5/n] 📖 Doc examples for external code #38915

merged 4 commits into from
Aug 27, 2023

Conversation

woshiyyya
Copy link
Member

@woshiyyya woshiyyya commented Aug 25, 2023 •
edited
Loading

Why are these changes needed?

Enables the new persistence mode for 📖 Doc examples for external code.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@woshiyyya
init
404bfcd 
Signed-off-by: woshiyyya <[email protected]>
@github-actions
Copy link

Attention: External code changed

This PR changes code that is used or cited in external sources, e.g. blog posts.

Before merging this PR, please make sure that the code in the external sources is still working, and consider updating them to reflect the changes.

The affected files and the external sources are:

@woshiyyya woshiyyya added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Aug 25, 2023
@woshiyyya woshiyyya marked this pull request as ready for review August 27, 2023 03:22
@woshiyyya woshiyyya requested a review from a team as a code owner August 27, 2023 03:22
@woshiyyya woshiyyya mentioned this pull request Aug 27, 2023
Open
@woshiyyya
rm _checkpoint
28708a4 
Signed-off-by: woshiyyya <[email protected]>
matthewdeng
matthewdeng reviewed Aug 27, 2023
View reviewed changes
doc/external/pytorch_tutorials_hyperparameter_tuning_tutorial.py Outdated
import torch
import torch.nn as nn
import torch.nn.functional as F
import torch.optim as optim
from torch.utils.data import random_split
import torchvision
import torchvision.transforms as transforms
import ray
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this? Or should this be import ray.train

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, or just use train only. Let me remove it

@woshiyyya
rm import ray
dd65919 
Signed-off-by: woshiyyya <[email protected]>
@matthewdeng matthewdeng merged commit 9276e41 into ray-project:master Aug 27, 2023
2 checks passed
matthewdeng pushed a commit to matthewdeng/ray that referenced this pull request Aug 30, 2023
@woshiyyya @matthewdeng
[2.7 CI][New Persistent Mode][5/n] 📖 Doc examples for external code (r…
60025fd 
…ay-project#38915)

Signed-off-by: woshiyyya <[email protected]>
GeneDer pushed a commit that referenced this pull request Aug 30, 2023
@matthewdeng @justinvyu
@woshiyyya @krfricke @ericl @xwjiang2010
[train][2.7] cherry-picks for documentations, tests, examples (#39105)
9e71973 
* [train] enable new persistence mode for core and serve tests (#38938)

Signed-off-by: Matthew Deng <[email protected]>

* [train] New persistence mode: Update 🐠 `ML Libraries w/ Ray Client Examples (Python 3.7)` (#38923)

Signed-off-by: Justin Yu <[email protected]>

* [train] remove non-URI assertion (#38944)

Signed-off-by: Matthew Deng <[email protected]>

* [train] New persistence mode: Update 📖 `Doc tests and examples (excluding Ray AIR examples)` (#38940)

Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Matthew Deng <[email protected]>
Co-authored-by: Matthew Deng <[email protected]>

* disable legacy sync config logic in trainable (#38952)

Signed-off-by: Justin Yu <[email protected]>

* [2.7 CI][New Persistent Mode][6/n] 📖 ✈️ Ray AIR examples (#38918)

Signed-off-by: woshiyyya <[email protected]>

* [2.7 CI][New Persistent Mode][2/n] 📺 📖 Doc GPU tests and examples (#38905)


Signed-off-by: woshiyyya <[email protected]>

* [2.7 CI][New Persistent Mode][4/n] 📺 🚂 Train GPU tests & 🚂 Datasets Train Integration GPU Tests and Examples (#38910)



Signed-off-by: woshiyyya <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Co-authored-by: Justin Yu <[email protected]>

* [2.7 CI][New Persistent Mode][1/n] 📺 ✈️ AIR GPU tests (ray/air) & ⚡ :python: Lightning 2.0 Train GPU tests  (#38903)


Signed-off-by: woshiyyya <[email protected]>
Signed-off-by: Yunxuan Xiao <[email protected]>

* [train] Fix broken tune tests and support ray storage (#38950)

This PR re-introduces support for ray storage ray.init(storage="s3:https://...") and fixes a broken tune controller test.

Signed-off-by: Justin Yu <[email protected]>

* [train] New persistence mode: Finish migrating `xgb`, `lgbm` and `sklearn` trainers, checkpoints + tests (#38959)


Signed-off-by: Justin Yu <[email protected]>

* [2.7 CI][New Persistent Mode][5/n] 📖 Doc examples for external code (#38915)

Signed-off-by: woshiyyya <[email protected]>

* [train][rllib] temporarily disable new persistence mode for rllib tests (#38965)

Signed-off-by: Matthew Deng <[email protected]>

* [2.7 CI][New Persistent Mode][8/n] ✈️ AIR tests (ray/air) (#38932)

Signed-off-by: woshiyyya <[email protected]>

* [tune] Storage: 🐙 🧠 Tune tests and examples {using RLlib} migration (#38895)

Signed-off-by: Kai Fricke <[email protected]>
Co-authored-by: matthewdeng <[email protected]>

* [train] Fix MosaicTrainer example and unit test (#38970)

Signed-off-by: Justin Yu <[email protected]>

* [air/release] Fix dreambooth example image preprocessing logic (#39020)

Signed-off-by: Justin Yu <[email protected]>

* [train] clean up ray.train._checkpoint imports (#38951)

Signed-off-by: Matthew Deng <[email protected]>

* [train] high level cleanup of Ray Train docs (#38971)

Signed-off-by: Matthew Deng <[email protected]>

* [wip][docs] update FrameworkPredictor examples (#38634)


Signed-off-by: Matthew Deng <[email protected]>
Signed-off-by: matthewdeng <[email protected]>

* [train] Add documentation for using metadata argument to save preprocessors (#38701)

* [Train] Restructure Ray Train Example Page (#38814)

Signed-off-by: woshiyyya <[email protected]>

* [air] Deprecate some fields/classes that are supposed to be gone in 2.6. (#38794)

Signed-off-by: xwjiang2010 <[email protected]>

* [tune/storage] Fix Tune multinode tests (#39050)

Fixes multinode tests by using the new train.report() API.

Signed-off-by: Kai Fricke <[email protected]>

* [tune] Fix BOHB example for new storage (#38983)

The new storage path does not create "empty" checkpoints per default anymore. Previously, when no checkpoint is saved, PAUSEing a trial would create a dummy checkpoint that only contains trial metadata (such as the iteration number). This is not the case anymore.

Examples now have to implement checkpointing to properly restore previous state. This was also true previously - but some of our simple examples (e.g. the one in this PR) didn't implement it and still "worked".

I think it's fine to keep the functionality as is and require our examples to show checkpointing implementations. This will ensure that users don't shoot their feet trying to use e.g. BOHB.

Separately, BOHB was malfunctioning as trials were repeatedly PAUSED and restarted as they've never been removed from `bracket.trials_to_unpause`. @justinvyu mentioned this in the review where it was introduced and I believed at the time it wasn't necessary - turns out it is, as we can end up in a situation where a bracket is never finished because trials are constantly running. This was not caught by any tests. We should add one in a follow-up - for now we can proceed with this PR to pick onto Ray 2.7.

Signed-off-by: Kai Fricke <[email protected]>

* [Release Test] Fix `long_running_horovod_tune_test`. (#39012)

Signed-off-by: Yunxuan Xiao <[email protected]>
Signed-off-by: Yunxuan Xiao <[email protected]>

* [train] New persistence mode: `StorageContext` unit tests (#39023)

Signed-off-by: Justin Yu <[email protected]>

* [train] enable train + tune tests and examples (#39021)

Signed-off-by: Matthew Deng <[email protected]>

* [rllib] Fix storage-path related tests (#38947)

This PR fixes rllib-related tests that didn't pass changes related to the new storage context.

Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: matthewdeng <[email protected]>
Co-authored-by: matthewdeng <[email protected]>

* [train] New persistence mode: Migrate 🐙 `Tune tests and examples (medium)` (#39081)

Signed-off-by: Justin Yu <[email protected]>

---------

Signed-off-by: Matthew Deng <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: woshiyyya <[email protected]>
Signed-off-by: Yunxuan Xiao <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: matthewdeng <[email protected]>
Signed-off-by: xwjiang2010 <[email protected]>
Signed-off-by: Yunxuan Xiao <[email protected]>
Co-authored-by: Justin Yu <[email protected]>
Co-authored-by: Yunxuan Xiao <[email protected]>
Co-authored-by: Kai Fricke <[email protected]>
Co-authored-by: Eric Liang <[email protected]>
Co-authored-by: xwjiang2010 <[email protected]>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@woshiyyya @arvind-chandra
[2.7 CI][New Persistent Mode][5/n] 📖 Doc examples for external code (r…
a6ffe8d 
…ay-project#38915)

Signed-off-by: woshiyyya <[email protected]>
Signed-off-by: e428265 <[email protected]>
LeonLuttenberger pushed a commit to jaidisido/ray that referenced this pull request Sep 5, 2023
@woshiyyya @LeonLuttenberger
[2.7 CI][New Persistent Mode][5/n] 📖 Doc examples for external code (r…
0426990 
…ay-project#38915)

Signed-off-by: woshiyyya <[email protected]>
jimthompson5802 pushed a commit to jimthompson5802/ray that referenced this pull request Sep 12, 2023
@woshiyyya @jimthompson5802
[2.7 CI][New Persistent Mode][5/n] 📖 Doc examples for external code (r…
3024afa 
…ay-project#38915)

Signed-off-by: woshiyyya <[email protected]>
Signed-off-by: Jim Thompson <[email protected]>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@woshiyyya
[2.7 CI][New Persistent Mode][5/n] 📖 Doc examples for external code (r…
ad7249a 
…ay-project#38915)

Signed-off-by: woshiyyya <[email protected]>
Signed-off-by: Victor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdeng matthewdeng matthewdeng approved these changes

Assignees

@justinvyu justinvyu

@matthewdeng matthewdeng

Labels
external-code-affected tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@woshiyyya @matthewdeng @justinvyu