[Data] Store serialized ParquetFileFragment in _ParquetDatasourceReader #38797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cheng Su <[email protected]>
Signed-off-by: Cheng Su <[email protected]>
c21
requested review from
ericl,
scv119,
amogkam,
scottjlee,
bveeramani and
raulchen
as code owners
Signed-off-by: Cheng Su <[email protected]>
|
Rerun the release test (link), and verified the time dropped to be same as before: |
raulchen
approved these changes
Aug 23, 2023
amogkam
approved these changes
Aug 23, 2023
scottjlee
approved these changes
Aug 24, 2023
|
This PR is bugfix to resolve data release test blocker - #38790 . cc @zhe-thoughts for review. |
zhe-thoughts
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
This qualifies as a release blocker.
@c21 I'll trust you to give me a green light when CI looks good. Then I will merge
|
@zhe-thoughts - yes, I checked the CI and the failure tests are not related. |
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…er (ray-project#38797) * Store serialized ParquetFileFragment in _ParquetDatasourceReader Signed-off-by: Cheng Su <[email protected]> Signed-off-by: e428265 <[email protected]>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…er (ray-project#38797) * Store serialized ParquetFileFragment in _ParquetDatasourceReader Signed-off-by: Cheng Su <[email protected]> Signed-off-by: Victor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Found regression in release test - #38790, where Parquet metdata fetching become slow. I suspect this is related to the ParquetFileFragment serialization triggered inside _ParquetDatasourceReader. So trying out this fix to see if release test gets fixed.
Related issue number
#38790
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.