Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Make vm launcher docs consistent regarding ray team vs community support #38529

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

architkulkarni
Copy link
Contributor

Why are these changes needed?

  • Add back Aliyun cluster launcher documentation that was removed (not sure why, I'm guessing it got lost in the shuffle when the cluster docs were reorganized last year.)
  • Group cluster launcher tabs into "Ray Team Supported" and "Community Supported"
  • Add vSphere to lists of community-supported cluster launchers

This makes the type of support more clear to users. This is what the tabs look like:

Screenshot 2023-08-16 at 3 45 34 PM Screenshot 2023-08-16 at 3 46 06 PM

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@architkulkarni
Copy link
Contributor Author

Hi @vinodkri and @LaynePeng! Are you okay with being listed as the points of contact here?

Signed-off-by: Archit Kulkarni <[email protected]>
@LaynePeng
Copy link
Contributor

Hi @vinodkri and @LaynePeng! Are you okay with being listed as the points of contact here?

Yes, sure. You can put me as the contract point.

@ericl ericl merged commit dea8ad7 into ray-project:master Aug 21, 2023
16 checks passed
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…y support (ray-project#38529)

- Add back Aliyun cluster launcher documentation that was removed (not sure why, I'm guessing it got lost in the shuffle when the cluster docs were reorganized last year.)
- Group cluster launcher tabs into "Ray Team Supported" and "Community Supported"
- Add vSphere to lists of community-supported cluster launchers

This makes the type of support more clear to users. This is what the tabs look like:

<img width="848" alt="Screenshot 2023-08-16 at 3 45 34 PM" src="https://github.com/ray-project/ray/assets/5459654/1a0e1d65-56b3-44cd-86df-5ba2a05f18f5">
<img width="772" alt="Screenshot 2023-08-16 at 3 46 06 PM" src="https://github.com/ray-project/ray/assets/5459654/4b2ee596-d974-4282-930b-a55fe4ead91f">

Signed-off-by: e428265 <[email protected]>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…y support (ray-project#38529)

- Add back Aliyun cluster launcher documentation that was removed (not sure why, I'm guessing it got lost in the shuffle when the cluster docs were reorganized last year.)
- Group cluster launcher tabs into "Ray Team Supported" and "Community Supported"
- Add vSphere to lists of community-supported cluster launchers

This makes the type of support more clear to users. This is what the tabs look like:

<img width="848" alt="Screenshot 2023-08-16 at 3 45 34 PM" src="https://github.com/ray-project/ray/assets/5459654/1a0e1d65-56b3-44cd-86df-5ba2a05f18f5">
<img width="772" alt="Screenshot 2023-08-16 at 3 46 06 PM" src="https://github.com/ray-project/ray/assets/5459654/4b2ee596-d974-4282-930b-a55fe4ead91f">

Signed-off-by: Victor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants