[all_tests][core][dashboard] Fix node logical resources reporting with autoscaler v2 #38440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rickyyx <[email protected]>
chaowanggg
reviewed
Aug 15, 2023
| parse_usage(usage_dict, verbose=True) | ||
| ) | ||
|
|
||
| return per_node_resources |
There was a problem hiding this comment.
Do you have a example data for per_node_resources? I would like to confirm the frontend would render as expected
There was a problem hiding this comment.
{
'nodeLogicalResources': {
'6eb8d224b678a6793679cc189e7bc3ef787033005bc3de61ad3d29a2': '0.0/1.0 CPU\n0B/27.53GiB memory\n0B/13.76GiB object_store_memory'
}
}
There was a problem hiding this comment.
also see the added e2e test.
chaowanggg
reviewed
Aug 15, 2023
| def test_get_nodes_summary(call_ray_start): | ||
|
|
||
| # The sleep is needed since it seems a previous shutdown could be not yet | ||
| # done when the next test starts. This prevents a previous cluster to be |
There was a problem hiding this comment.
Good catch! I believe I met the similar issue before
|
LGTM! |
chaowanggg
approved these changes
Aug 15, 2023
|
Release test with v2 working with logcial node rsources: |
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…r v2 (ray-project#38440) Signed-off-by: rickyyx <[email protected]> Signed-off-by: harborn <[email protected]>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…r v2 (ray-project#38440) Signed-off-by: rickyyx <[email protected]>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…r v2 (ray-project#38440) Signed-off-by: rickyyx <[email protected]> Signed-off-by: e428265 <[email protected]>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…r v2 (ray-project#38440) Signed-off-by: rickyyx <[email protected]> Signed-off-by: Victor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
With autoscaler v2, we no longer have monitor process writing the status into kv value store, instead, we could get the data from GCS directly through
get_cluster_status, so we use that instead to populate logical resources info.Added unit testing.
Related issue number
Closes #38404
Closes #38332
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.