[Data] Improve _resolve_paths_and_filesystem error message
#38366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <[email protected]>
bveeramani
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee and
raulchen
as code owners
Signed-off-by: Balaji Veeramani <[email protected]>
c21
approved these changes
Aug 11, 2023
bveeramani
added
the
tests-ok
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
…ject#38366) If you pass an invalid input to _resolve_paths_and_filesystem, you get an error message telling you what types are valid, but it doesn't tell you what you passed it. > paths must be a path string or a list of path strings. This PR updates the error message to describe what you passed in: > 'Expected paths to be a str, pathlib.Path, or list[str], but got None' Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: NripeshN <[email protected]>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…ject#38366) If you pass an invalid input to _resolve_paths_and_filesystem, you get an error message telling you what types are valid, but it doesn't tell you what you passed it. > paths must be a path string or a list of path strings. This PR updates the error message to describe what you passed in: > 'Expected paths to be a str, pathlib.Path, or list[str], but got None' Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: harborn <[email protected]>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…ject#38366) If you pass an invalid input to _resolve_paths_and_filesystem, you get an error message telling you what types are valid, but it doesn't tell you what you passed it. > paths must be a path string or a list of path strings. This PR updates the error message to describe what you passed in: > 'Expected paths to be a str, pathlib.Path, or list[str], but got None' Signed-off-by: Balaji Veeramani <[email protected]>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…ject#38366) If you pass an invalid input to _resolve_paths_and_filesystem, you get an error message telling you what types are valid, but it doesn't tell you what you passed it. > paths must be a path string or a list of path strings. This PR updates the error message to describe what you passed in: > 'Expected paths to be a str, pathlib.Path, or list[str], but got None' Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: e428265 <[email protected]>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…ject#38366) If you pass an invalid input to _resolve_paths_and_filesystem, you get an error message telling you what types are valid, but it doesn't tell you what you passed it. > paths must be a path string or a list of path strings. This PR updates the error message to describe what you passed in: > 'Expected paths to be a str, pathlib.Path, or list[str], but got None' Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: Victor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
If you pass an invalid input to
_resolve_paths_and_filesystem, you get an error message telling you what types are valid, but it doesn't tell you what you passed it.This PR updates the error message to describe what you passed in:
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.