-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data] Add Datasource.on_write_start
#38298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <[email protected]>
Nice find!
…On Wed, Aug 9, 2023, 10:35 PM Balaji Veeramani ***@***.***> wrote:
@bveeramani <https://github.com/bveeramani> requested your review on:
#38298 <#38298> [Data] Add
Datasource.on_write_start as a code owner.
—
Reply to this email directly, view it on GitHub
<#38298 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADUSWH6RCKSGQNPYCLIKLXURXK3ANCNFSM6AAAAAA3K6RD4U>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
@c21 Here's the currently failing test:
|
…te-start Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
c21
reviewed
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change with on_write_start
LGTM. As discussed offline, let's delete the staging directory if no file is written.
Signed-off-by: Balaji Veeramani <[email protected]>
…oject/ray into bveeramani/on-write-start Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
c21
reviewed
Aug 11, 2023
Signed-off-by: Balaji Veeramani <[email protected]>
Appease lint Signed-off-by: Balaji Veeramani <[email protected]>
Add unit tests Signed-off-by: Balaji Veeramani <[email protected]>
Appease lint Signed-off-by: Balaji Veeramani <[email protected]>
Remove extra files Signed-off-by: Balaji Veeramani <[email protected]>
Remove unnecessary file Signed-off-by: Balaji Veeramani <[email protected]>
Update BUILD Signed-off-by: Balaji Veeramani <[email protected]>
Rename `created_dir` to `has_created_dir` Signed-off-by: Balaji Veeramani <[email protected]>
c21
approved these changes
Aug 14, 2023
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
Currently, we attempt to create a directory in every write task. This can cause rate limiting issues with S3. To address this problem, this PR adds a on_write_start method that is executed once per write job. Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: NripeshN <[email protected]>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
Currently, we attempt to create a directory in every write task. This can cause rate limiting issues with S3. To address this problem, this PR adds a on_write_start method that is executed once per write job. Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: harborn <[email protected]>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
Currently, we attempt to create a directory in every write task. This can cause rate limiting issues with S3. To address this problem, this PR adds a on_write_start method that is executed once per write job. Signed-off-by: Balaji Veeramani <[email protected]>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Currently, we attempt to create a directory in every write task. This can cause rate limiting issues with S3. To address this problem, this PR adds a on_write_start method that is executed once per write job. Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: e428265 <[email protected]>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
Currently, we attempt to create a directory in every write task. This can cause rate limiting issues with S3. To address this problem, this PR adds a on_write_start method that is executed once per write job. Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: Victor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, we attempt to create a directory in every write task. This can cause rate limiting issues with S3. To address this problem, this PR adds a
on_write_start
method that is executed once per write job.Related issue number
Fixes #36690
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.