Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Remove option to disable block splitting #38235

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Aug 8, 2023

Why are these changes needed?

Dynamic block splitting has been enabled by default for a couple of releases. To improve the maintainability of our codebase, this PR removes the option to disable block splitting and removes related code paths.

Related issue number

Discussion in this thread: #38026

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <[email protected]>
Copy link
Contributor

@ericl ericl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! So happy we've matured dynamic args enough to be fully removing the old path.

@bveeramani bveeramani added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Aug 9, 2023
@bveeramani
Copy link
Member Author

Failing test is unrelated

@bveeramani bveeramani merged commit 8afcf9b into ray-project:master Aug 9, 2023
60 of 63 checks passed
@bveeramani bveeramani deleted the remove-block-splitting branch August 9, 2023 02:24
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
Dynamic block splitting has been enabled by default for a couple of releases. To improve the maintainability of our codebase, this PR removes the option to disable block splitting and removes related code paths.

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: NripeshN <[email protected]>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
Dynamic block splitting has been enabled by default for a couple of releases. To improve the maintainability of our codebase, this PR removes the option to disable block splitting and removes related code paths.

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: harborn <[email protected]>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
Dynamic block splitting has been enabled by default for a couple of releases. To improve the maintainability of our codebase, this PR removes the option to disable block splitting and removes related code paths.

Signed-off-by: Balaji Veeramani <[email protected]>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Dynamic block splitting has been enabled by default for a couple of releases. To improve the maintainability of our codebase, this PR removes the option to disable block splitting and removes related code paths.

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: e428265 <[email protected]>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
Dynamic block splitting has been enabled by default for a couple of releases. To improve the maintainability of our codebase, this PR removes the option to disable block splitting and removes related code paths.

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Victor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants