Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix typo in Semgrep config #38175

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

#38126 attempted to correct an unnecessary newline in the error message:

         Don't use 'code-block:: python', it's not tested! Use 'testcode'
  instead! For more
          information, see
  https://docs.ray.io/en/master/ray-contribute/writing-code-snippets.html.

But, the updated error message is missing quotes. As a result, the CI is always passing.

image (2)

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani merged commit 56ff789 into ray-project:master Aug 7, 2023
118 of 127 checks passed
@bveeramani bveeramani deleted the fix-config-error branch August 7, 2023 18:54
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
ray-project#38126 attempted to correct an unnecessary newline in the error message. But, the updated error message is missing quotes. As a result, the CI is always passing.

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: NripeshN <[email protected]>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
ray-project#38126 attempted to correct an unnecessary newline in the error message. But, the updated error message is missing quotes. As a result, the CI is always passing.

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: harborn <[email protected]>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
ray-project#38126 attempted to correct an unnecessary newline in the error message. But, the updated error message is missing quotes. As a result, the CI is always passing.

Signed-off-by: Balaji Veeramani <[email protected]>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
ray-project#38126 attempted to correct an unnecessary newline in the error message. But, the updated error message is missing quotes. As a result, the CI is always passing.

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: e428265 <[email protected]>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
ray-project#38126 attempted to correct an unnecessary newline in the error message. But, the updated error message is missing quotes. As a result, the CI is always passing.

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Victor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants