Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cluster] Fix Kuberay capitalization #37791

Merged

Conversation

architkulkarni
Copy link
Contributor

@architkulkarni architkulkarni commented Jul 25, 2023

Why are these changes needed?

replace Kuberay with KubeRay, and add Kuberay to the list of banned words in the linter

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Sep 17, 2023
@architkulkarni architkulkarni changed the title Fix Kuberay capitalization [Cluster] Fix Kuberay capitalization Sep 22, 2023
@architkulkarni architkulkarni marked this pull request as ready for review September 22, 2023 16:51
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the documentation changes. Let's wait for the Autoscaler tests to pass.

@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Sep 22, 2023
@architkulkarni
Copy link
Contributor Author

@angelinalg would you mind approving this on behalf of ray-docs?

Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this attention to detail. And I really appreciate you adding it to the linter. Thank you! There's also a Vale (go/vale) linter that we use. I'll see if we should consolidate the linting. cc: @bveeramani

@DmitriGekhtman
Copy link
Contributor

kUBeraY

bveeramani added a commit that referenced this pull request Oct 10, 2023
follow up to #37791. We have two places to fix this. Let's fix it in Vale, too.

---------

Signed-off-by: angelinalg <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Co-authored-by: Balaji Veeramani <[email protected]>
@architkulkarni
Copy link
Contributor Author

@scv119 assigning you as core-oncall just for the codeowner stamp!

Copy link
Member

@hongchaodeng hongchaodeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@architkulkarni architkulkarni merged commit b21831e into ray-project:master Nov 27, 2023
60 of 64 checks passed
@architkulkarni architkulkarni deleted the kuberay-capitalization-ban branch November 27, 2023 17:23
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
replace Kuberay with KubeRay, and add Kuberay to the list of banned words in the linter

---------

Signed-off-by: Archit Kulkarni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants