-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cluster] Fix Kuberay capitalization #37791
[Cluster] Fix Kuberay capitalization #37791
Conversation
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
Signed-off-by: Archit Kulkarni <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the documentation changes. Let's wait for the Autoscaler tests to pass.
@angelinalg would you mind approving this on behalf of ray-docs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this attention to detail. And I really appreciate you adding it to the linter. Thank you! There's also a Vale (go/vale) linter that we use. I'll see if we should consolidate the linting. cc: @bveeramani
kUBeraY |
follow up to #37791. We have two places to fix this. Let's fix it in Vale, too. --------- Signed-off-by: angelinalg <[email protected]> Signed-off-by: Balaji Veeramani <[email protected]> Co-authored-by: Balaji Veeramani <[email protected]>
…ray-capitalization-ban Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
…tkulkarni/ray into kuberay-capitalization-ban Signed-off-by: Archit Kulkarni <[email protected]>
@scv119 assigning you as core-oncall just for the codeowner stamp! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
replace Kuberay with KubeRay, and add Kuberay to the list of banned words in the linter --------- Signed-off-by: Archit Kulkarni <[email protected]>
Why are these changes needed?
replace Kuberay with KubeRay, and add Kuberay to the list of banned words in the linter
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.